cxx-qt-build: ensure that we set framework path for inner cc builds #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayzen-kdab
added
the
⏮️ backport-candidate
ahayzen-kdab
force-pushed
the
147-add-framework-path-to-cc-builders
branch
from
b1e7086 to
308c36a
Compare
Closed
ahayzen-kdab
force-pushed
the
147-add-framework-path-to-cc-builders
branch
from
308c36a to
fa8f374
Compare
ahayzen-kdab
force-pushed
the
147-add-framework-path-to-cc-builders
branch
from
fa8f374 to
eb59614
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #970 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 11949 11949
=========================================
Hits 11949 11949 ☔ View full report in Codecov by Sentry. |
ahayzen-kdab
force-pushed
the
147-add-framework-path-to-cc-builders
branch
2 times, most recently
from
626c2dd to
eceb34d
Compare
|
Note that this is similar to #630 and does very similar changes but with the new build system changes. |
ahayzen-kdab
force-pushed
the
147-add-framework-path-to-cc-builders
branch
5 times, most recently
from
4eabe9f to
3918976
Compare
Otherwise the @rpath cannot be found at runtime
ahayzen-kdab
force-pushed
the
147-add-framework-path-to-cc-builders
branch
from
3918976 to
fa50302
Compare
LeonMatthesKDAB
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #885